refactor: refactor types

[D-Sketon]

now

this.findById(id, { lean: true }); // <-- T
this.findById(id, { lean: false }); // <-- Document<T>
this.findById(id, {}); // <-- Document<T>
this.findById(id, {} as Partial<Options>); // <-- Document<T> | T

[coveralls]

Pull Request Test Coverage Report for Build 9732452201

Details

• 123 of 123 (100.0%) changed or added relevant lines in 7 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 98.295%

---

Totals
Change from base Build 9700112432:	0.02%
Covered Lines:	4438
Relevant Lines:	4515

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9797301066

Details

• 140 of 140 (100.0%) changed or added relevant lines in 7 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 98.295%

---

Totals
Change from base Build 9700112432:	0.02%
Covered Lines:	4438
Relevant Lines:	4515

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9817607131

Details

• 185 of 185 (100.0%) changed or added relevant lines in 7 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 98.289%

---

Totals
Change from base Build 9700112432:	0.01%
Covered Lines:	4424
Relevant Lines:	4501

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9819663515

Details

• 186 of 186 (100.0%) changed or added relevant lines in 7 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 98.29%

---

Totals
Change from base Build 9700112432:	0.02%
Covered Lines:	4425
Relevant Lines:	4502

---

💛 - Coveralls

[D-Sketon]

warehouse/src/model.ts

Lines 79 to 82 in af981d3

	Object.assign(this, schema.statics);
	// Apply instance methods
	Object.assign(_Document.prototype, schema.methods);

Solve the above code, but as with #252, it's not a good solution. Model knows nothing about static and method types in Schema.
@SukkaW Do you have any good solutions?

[D-Sketon]

I was going to add another generic for setting the type of static and method, but its not possible to act directly on the class.

interface Extra {
  statics: Record<string, (...args: any[]) => any>;
  methods: Record<string, (...args: any[]) => any>;
}

type AddThis<R extends Record<string, (...args: any[]) => any>, T> = {
  [K in keyof R]: (this: T, ...args: Parameters<R[K]>) => ReturnType<R[K]>;
}

class Schema<T = any, K extends Partial<Extra> = Extra> {
  statics!: K['statics'] extends Record<string, (...args: any[]) => any> ? AddThis<K['statics'], T> : Record<string, (this: T, ...args: any[]) => any>;
  methods!: K['methods'] extends Record<string, (...args: any[]) => any> ? AddThis<K['methods'], T> : Record<string, (this: T, ...args: any[]) => any>;

}

interface AssetSchema {
  _id: string
}

const a = new Schema<AssetSchema, {
  statics: {
    add: (a: number, b: number) => number;
  }
}>().statics.add // <-- (this: AssetSchema, a: number, b: number) => ReturnType<(a: number, b: number) => number>

const b = new Schema<AssetSchema>().methods // <-- AddThis<Record<string, (...args: any[]) => any>, AssetSchema>

class Model<T, K extends Partial<Extra> = Extra> {
  schema!: Schema<T, K>
  // [key in keyof K['statics']]: K['statics'][key] illegal
}

[SukkaW]

I have some vague ideas about this:

• We can modify the Schema type so that virtual (and others) will "concat" the type information and return the new Schema type.
  • A similar implementation can be found here, where @commander-js/extra-typings allows command.option().option().option().option() to be typed: https://github.com/commander-js/extra-typings/blob/e53229bf91e73df4a1b5b6be3ef39b1737397b63/index.d.ts#L938-L957
• With the new Schema type Model should be able to infer the methods.

We can do this in another PR.

[coveralls]

Pull Request Test Coverage Report for Build 12721566187

Details

• 186 of 186 (100.0%) changed or added relevant lines in 7 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 98.297%

---

Totals
Change from base Build 12654109413:	0.01%
Covered Lines:	4444
Relevant Lines:	4521

---

💛 - Coveralls

[uiolee]

scripts preeslint, pretest could be deleted.

warehouse/package.json

Line 16 in ca7f851

"preeslint": "npm run clean && npm run build",

warehouse/package.json

Line 18 in ca7f851

"pretest": "npm run clean && npm run build",

[uiolee]

Conflicts with branch master's code, could you update them?