-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1098) Add docs about escape option in post_link & asset_link helpers #1102
Conversation
PR LGTM. But somehow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need workaround
d8a4f1d
to
f6e1c2e
Compare
@curbengh |
95233d2
to
3032d31
Compare
😕 Removing package-lock.json (as what you did) looks like a good approach. But instead of removing it in every build, you can add Let's try |
3032d31
to
340d456
Compare
@dailyrandomphoto |
Ok. thank you.
I think this is a reliable and reasonable approach. So we can control the version of that we want. |
I'm wary of that approach as it introduce additional maintenance work. I just had another idea, Switch to |
Check List
Please read and check followings before submitting a PR.
link
URL is correct.preview
URL is correct.preview
URL web site is rendered correctly.source/themes/screenshots
.name
.800 * 500
.png
.link
URL is correct.Closes #1098
Related hexojs/hexo#3704