feat: load hexo plugin in the theme's package.json

[stevenjoezhang]

What does it do?

Resolve hexojs/hexo-renderer-marked#205 (comment)
See also #4112 #2558 #3890 (comment)

How to test

git clone -b theme-pluginhttps://github.com/hexojs/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

• Add test cases for the changes.
• Passed the CI test.

[coveralls]

Coverage remained the same at 98.282% when pulling ce02bcf on theme-plugin into 042f862 on master.

[stevenjoezhang]

Both the dependencies and devDependencies in the Hexo package.json will be loaded as hexo plugins
Only the dependencies in the theme package.json will be loaded (if installed)

If you have any other suggestions, please reply here.

[jiangtj]

devDependencies are used in the current project for test or build, I think they should be ignored.

I am more concerned about peerdependencies. In npm, it should be used to declare the host environment dependency, which is suitable for our plug-ins. However, the actual performance of peerdependencies is different in npm6 (node ​​14) and npm7. Npm6 will not automatically install peerdependencies dependencies.

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependencies

I think we should consider support for peerdependencies in future versions

[stevenjoezhang]

I do agree to ignore devDependencies, this will revert #2558

[SukkaW]

Any unit test can be added?

[SukkaW]

Also, maybe we need a separated Node.js 12 PR before this can be merged.

[stevenjoezhang]

Also, maybe we need a separated Node.js 12 PR before this can be merged.

PR opened: #4779

[SukkaW]

@stevenjoezhang #4779 is merged. Would you mind rebasing the PR with the latest master branch? Otherwise, GitHub Action's Lint task will never pass.

Also, Would you mind adding a test case for the PR here? Just to make sure package.json under theme_dir is indeed being read and executed.

[stevenjoezhang]

This line will reset Hexo package.json, to make sure in the following unit tests, hexo-plugin-test plugin is loaded from theme's package.json, not Hexo package.json

[jiangtj]

It seems that the plugin defined in the theme will override the one under hexo. The priority in the theme is higher, but the plugin under hexo is added by the user. I think it should have a higher priority.

[stevenjoezhang]

There are two different considerations:

• The priority in the Hexo package.json is higher: If the theme is not maintained, the users will be able to override the outdated plugins defined in theme package.json
• The priority in the theme is higher: The plugin in Hexo package.json may not be compatible with the theme, and the theme could provide a proper version for the users

[jiangtj]

There are two different considerations:

Yesh, but I prefer the first one. After all, if you use the plugin defined by the theme, you only need to remove the relevant plugins in your package.json. In the second option, I will not be able to cover the plugins inside the theme.

Or take a poll? 😂

[jiangtj]

👍