Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(box): ignore correct .git and node modules in the theme folder #4306

Merged
merged 5 commits into from
May 18, 2020
Merged

fix(box): ignore correct .git and node modules in the theme folder #4306

merged 5 commits into from
May 18, 2020

Conversation

jiangtj
Copy link
Member

@jiangtj jiangtj commented May 12, 2020

What does it do?

Ignore correct .git and node modules in the theme folder

How to test

git clone -b fix-watch-ignore https://github.com/jiangtj/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0006%) to 97.745% when pulling 8244e5f on jiangtj:fix-watch-ignore into 515cf6f on hexojs:master.

SukkaW
SukkaW approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stevenjoezhang stevenjoezhang linked an issue May 14, 2020 that may be closed by this pull request
The proposal of installing theme through npm #3890
Closed
@SukkaW SukkaW merged commit 956242e into hexojs:master May 18, 2020
@SukkaW SukkaW mentioned this pull request Jul 25, 2020
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The proposal of installing theme through npm
3 participants
@jiangtj @coveralls @SukkaW