Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(github actions): Create tester job #4169

Merged
merged 1 commit into from
Apr 26, 2020
Merged

feat(github actions): Create tester job #4169

merged 1 commit into from
Apr 26, 2020

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Mar 2, 2020

What does it do?

How to test

git clone -b BRANCH https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@segayuu segayuu requested review from SukkaW and curbengh March 2, 2020 09:01
@segayuu segayuu force-pushed the create-tester-workflow branch 4 times, most recently from c8b6d82 to b2b39ec Compare March 2, 2020 09:22
SukkaW
SukkaW previously approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding macOS?

@segayuu segayuu force-pushed the create-tester-workflow branch 2 times, most recently from 1b6ef85 to 5827721 Compare March 2, 2020 12:44
@segayuu
Copy link
Contributor Author

segayuu commented Mar 2, 2020

Testing the Mac OS resulted in an error around the watch method. It can be said that the problem was discovered by this PR :)

@SukkaW
Copy link
Member

SukkaW commented Mar 2, 2020

@segayuu Well then, we could leave this PR here and dig into the macOS testing problem.

@segayuu
Copy link
Contributor Author

segayuu commented Mar 3, 2020

Since I don't have mac OS, I can check the operation only with CI.

@SukkaW
Copy link
Member

SukkaW commented Mar 4, 2020

Since I don't have mac OS, I can check the operation only with CI.

@segayuu It seems that all failed test cases are about ignoring files.

@segayuu
Copy link
Contributor Author

segayuu commented Mar 9, 2020

Implementation around ignore file depends on micromatch. This error may have been caused by the implementation of micromatch.

@segayuu segayuu force-pushed the create-tester-workflow branch from 42868c2 to 5827721 Compare March 9, 2020 12:37
@segayuu segayuu force-pushed the create-tester-workflow branch from 10d1530 to 0f35898 Compare March 9, 2020 13:13
@stevenjoezhang
Copy link
Member

stevenjoezhang commented Apr 26, 2020 •
edited
Loading

https://github.com/hexojs/hexo/pull/4169/checks?check_run_id=495143914#step:6:1233

截屏2020-04-26 上午9 34 02

I can reproduce three of the five failed tests on my mac. I will investigate whether more tests can be performed on micromatch.

#4269

@stevenjoezhang stevenjoezhang mentioned this pull request Apr 26, 2020
Merged
2 tasks
@SukkaW SukkaW merged commit c51b87e into hexojs:master Apr 26, 2020
@segayuu segayuu deleted the create-tester-workflow branch May 9, 2020 06:33
@yoshinorin yoshinorin mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

@curbengh curbengh Awaiting requested review from curbengh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@segayuu @SukkaW @stevenjoezhang