feat(load_plugins): ignore hexo-theme-[config.theme] #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
commented
Jan 31, 2020
SukkaW
force-pushed
the
feat-ignore-theme-in-plugin
branch
from
86f32df to
0f37309
Compare
SukkaW
force-pushed
the
feat-ignore-theme-in-plugin
branch
from
0f37309 to
4be9a99
Compare
yoshinorin
requested changes
Feb 15, 2020
SukkaW
force-pushed
the
feat-ignore-theme-in-plugin
branch
from
4be9a99 to
41cff3d
Compare
curbengh
reviewed
Feb 24, 2020
test/scripts/hexo/load_plugins.js
Outdated
| @@ -128,6 +128,23 @@ describe('Load plugins', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('ignore plugin whose name is "hexo-theme-[hexo.config.theme]"', () => { | |||
There was a problem hiding this comment.
suggest new tests to use async.
There was a problem hiding this comment.
Change to async and rebased.
SukkaW
force-pushed
the
feat-ignore-theme-in-plugin
branch
from
41cff3d to
991fcb6
Compare
yoshinorin
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
LGTM.
BTW, we should create the plugins option document. I can't find any document of it.
|
PS The Appveyor build was failed. But, my local PC (Windows node 13.0.1) test was passed. |
I believe the issue is related with Windows file system problem. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The part of #3890
#3890 (comment)
How to test
Screenshots
Pull request tasks