Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(travis): remove Windows #4076

Merged
merged 2 commits into from
Jan 13, 2020
Merged

ci(travis): remove Windows #4076

merged 2 commits into from
Jan 13, 2020

Conversation

curbengh
Copy link
Contributor

What does it do?

The workarounds #3975 #4069 still don't work reliably in Travis' Windows.
I also reverse the order of Node version in Appveyor, to prioritize newer Node (Appveyor starts the tests sequentially). This is to avoid the issue experienced in hexojs/hexo-fs#50.

How to test

git clone -b travis-disable-windows https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@curbengh curbengh requested a review from a team January 13, 2020 23:12
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.704% when pulling 2dd904d on curbengh:travis-disable-windows into 05a8a47 on hexojs:master.

@SukkaW SukkaW merged commit 5df9252 into hexojs:master Jan 13, 2020
@curbengh curbengh deleted the travis-disable-windows branch January 13, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @SukkaW