Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test-console-generate): async/await #3972

Merged
merged 8 commits into from
Jan 9, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 16, 2019

What does it do?

#3328

How to test

git clone -b test-console-generate https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 16, 2019

Coverage Status

Coverage remained the same at 97.086% when pulling 4499562 on curbengh:test-console-generate into 663f1eb on hexojs:master.

@curbengh curbengh force-pushed the test-console-generate branch from c5c4985 to 4499562 Compare December 31, 2019 00:14
@SukkaW SukkaW merged commit 814f843 into hexojs:master Jan 9, 2020
@curbengh curbengh deleted the test-console-generate branch January 10, 2020 07:10
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
* refactor(test-console-generate): async/await

* refactor(test-console-generate): destructure

* refactor(test-console-generate): arrow function

* style: spacing

* refactor(test-console-generate): remove all files before removing folder

- workaround for appveyor

* fix(test-console-generate): check folder before remove

* fix(test-console-generate): await fs.exists()

* style: asyncArrow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants