Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test-box-file): async/await #3954

Merged
merged 5 commits into from
Dec 27, 2019
Merged

refactor(test-box-file): async/await #3954

merged 5 commits into from
Dec 27, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 14, 2019 •
edited
Loading

What does it do?

#3328

I think it's viable to eventually replace chai-as-promised with async/await.

How to test

git clone -b test-box-file-async https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.138% when pulling ee10a0f on curbengh:test-box-file-async into e4a5292 on hexojs:master.

@coveralls
Copy link

coveralls commented Dec 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 97.137% when pulling c6ea649 on curbengh:test-box-file-async into e4a5292 on hexojs:master.

SukkaW
SukkaW reviewed Dec 14, 2019
View reviewed changes
test/scripts/box/file.js Outdated Show resolved Hide resolved
@SukkaW SukkaW mentioned this pull request Dec 14, 2019
Open
@curbengh curbengh requested a review from SukkaW December 17, 2019 09:57
@SukkaW SukkaW merged commit 5f0090c into hexojs:master Dec 27, 2019
@curbengh curbengh deleted the test-box-file-async branch December 30, 2019 09:41
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
refactor(test-box-file): async/await (hexojs#3954)
42c2467 
* refactor(test-box-file): async/await

* refactor(test-box-file): destructure

* refactor(test-box-file): arrow function

* chore(dev-deps): update eslint-config-hexo from 4.0 to 4.1

* style: asyncArrow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @SukkaW