-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(box): ignore node_modules/ & .git/ in themes #3918
Conversation
As I couldn't reproduce the original issue, I will mark this ready for review after affected users have confirmed this PR does fix the issue. |
It works for me. |
2b087c1
to
1f4afac
Compare
The benchmark finished a lot quicker than usual. Iterating through merged PRs, it starts from #3926. We need to test the master branch in a test blog. |
@curbengh I am already working on it.
|
It's from #3926, need null-check on |
Since you're working on it, feel free to submit fix. |
What does it do?
Continuation of #3797
Supersedes and closes hexojs/hexo-starter#30 cc @dailyrandomphoto
Related: #3885 hexojs/hexo-server#45 hexojs/hexo-server#43
How to test
cc @shen-yu
rm -f package-lock.json && rm -rf node_modules/
npm install
hexo clean && hexo server
Maintainers only:
Pull request tasks