Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop lodash & es6 syntax for lib/theme #3809

Merged
merged 1 commit into from
Oct 27, 2019
Merged

refactor: drop lodash & es6 syntax for lib/theme #3809

merged 1 commit into from
Oct 27, 2019

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Oct 27, 2019

What does it do?

This PR is a part of #3753, the continuation of #3807.

How to test

git clone -b reduce-lodash-lib-themehttps://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from curbengh October 27, 2019 11:52
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 97.266% when pulling 0eabb60 on SukkaW:reduce-lodash-lib-theme into 182fdf4 on hexojs:master.

@SukkaW SukkaW merged commit 73e7163 into hexojs:master Oct 27, 2019
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@SukkaW
refactor: drop lodash & es6 syntax for lib/theme (hexojs#3809)
e9ac8ef
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SukkaW @coveralls @curbengh