Breaking Changes for most Hexo themes in languages

[ivan-nginx]

For BUG

theme-next/hexo-theme-next#209

For feature request

#3069 (merged)

Explanation & Suggestion

#3069 (comment)

[bobd91]

This is a difficult problem as the documented behaviour (use 'default' language file if no language specified) did not work so you had to come up with some scheme that did work.

Relying on the behaviour of a bug is always risky, and the longer the bug takes to get fixed the more people rely on the buggy behaviour and the more pain fixing the bug causes.

However, this should not be classified as a breaking change. The behaviour that you and others relied upon was not a documented feature but the side-effect of a defect that was reported and scheduled to be fixed.

[ivan-nginx]

I understand this, but we have for now badly situation then it was before:

1. Before fix: new Hexo / Theme user just install Hexo & Theme and with default config settings see first language in list (at most cases it's en.yml). Anyway, he will see any language without any bugs, before he will define needed by him language in main Hexo config.
2. After fix: with same situation, user don't see any language and just see untranslated values like post.posted, footer.theme, etc. and will think what this bug of Theme or, at least, of Hexo.

This is big difference from point of view new Hexo users and create some troubles for Theme mainteiners under Hexo (from this pull need at least to create additional symlink or duplicate file to around this bugfix).

Anyway, i report attention about this and suggest decision in comment to resolve this situation without revert current changes.

[bobd91]

@ivan-nginx

you are of course correct, when a bug is this old many people will depend upon the buggy behaviour so it would be best if the fix did not break everything. I could have made it so that if a default file did not exist then it would fall back to the old method of selecting the file.

I have corrected this as pull request #3110. It is too late for you I know but hopefully it might help some others who have not updated their Hexo version yet.

[ivan-nginx]

I think u see my opinion and i appreciate this. All maintainers of themes under the Hexo will appreciate this too, i think. And, yes, i already import fix on this fix, but as for me, always need to have any competidors in similar things, to be better for all of us.