fix: opens external anchor using rel=noopener (#2728)

* fix: opens external anchor using rel=noopener see https://developers.google.com/web/tools/lighthouse/audits/noopener * fix: use external noopener as rel
hexojs · Aug 29, 2017 · dfb5a4b · dfb5a4b
1 parent 8162fd8
commit dfb5a4b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/plugins/helper/link_to.js b/lib/plugins/helper/link_to.js
@@ -23,7 +23,7 @@ function linkToHelper(path, text, options) {
 
   if (attrs.external) {
     attrs.target = '_blank';
-    attrs.rel = 'external';
+    attrs.rel = 'external noopener';
     attrs.external = null;
   }
 

diff --git a/test/scripts/helpers/link_to.js b/test/scripts/helpers/link_to.js
@@ -22,12 +22,12 @@ describe('link_to', () => {
 
   it('external (boolean)', () => {
     linkTo('http://hexo.io/', 'Hexo', true)
-      .should.eql('<a href="http://hexo.io/" title="Hexo" target="_blank" rel="external">Hexo</a>');
+      .should.eql('<a href="http://hexo.io/" title="Hexo" target="_blank" rel="external noopener">Hexo</a>');
   });
 
   it('external (object)', () => {
     linkTo('http://hexo.io/', 'Hexo', {external: true})
-      .should.eql('<a href="http://hexo.io/" title="Hexo" target="_blank" rel="external">Hexo</a>');
+      .should.eql('<a href="http://hexo.io/" title="Hexo" target="_blank" rel="external noopener">Hexo</a>');
   });
 
   it('class (string)', () => {