Render an absolute feed URL #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is an update to hexojs#29. This supposed to be a small PR, but I've encountered some issues regarding the base URL. The `[full_url_for](https://github.com/hexojs/hexo-util/blob/master/lib/full_url_for.js#L27)` function expects the `config.url` not to end with a forward slash. Otherwise it will create a double slash URL, e.g. `http://example.com//atom.xml` (notice that a double slash replacement happens only _after_ the base URL). I was wondering how the icon feature (hexojs#102) can be using `full_url_for` with the current code and not run into any double slash issues. The answer is: it doesn't handle this case. The [unit tests](https://github.com/hexojs/hexo-generator-feed/pull/102/files#diff-910eb6f57886ca16c136101fb1699231R240) are simply running against a custom base URL without an ending slash. I've cleaned up the tests: - removed the ending slash from the base URL - adjusted and added new tests to handle subdirectories correctly (as specified in the [hexo documentation](https://hexo.io/docs/configuration.html#URL)) - hard-coded expected values - it makes a test more reliable and readable
darekkay
force-pushed
the
feed-absolute-url
branch
from
1ebc2f0
to
a4d9bb6
Compare
jiangtj
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update to #29.
This supposed to be a small PR, but I've encountered some issues regarding the base URL.
The
full_url_forfunction expects theconfig.urlnot to end with a forward slash. Otherwise it will create a double slash URL, e.g.http://example.com//atom.xml(notice that a double slash replacement happens only after the base URL).I was wondering how the icon feature (#102) can be using
full_url_forwith the current code and not run into any double slash issues. The answer is: it doesn't handle this case. The unit tests are simply running against a custom base URL without an ending slash.So I've cleaned up the tests:
All in all, the RSS code itself was and is correct as far as I can judge it, but the tests were faulty.