fix: date localestring format error #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since node v18.13.0, ICU is updated to 72.1, which changes the behavior of 'en-CA' toLocaleString.
Its output could be formatted to
YYYY-MM-DD HH:mm:ss
, but now it becomesMM/DD/YYYY HH:mm:ss
, which is no longer a valid ISO 8601 representation.The
Date.prototype.toJSON
orDate.prototype.toISOString
is guaranteed to produce ISO 8601 format string, so we can use these methods instead.