Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate typescript #59

Merged
merged 1 commit into from
Oct 28, 2022
Merged

refactor: migrate typescript #59

merged 1 commit into from
Oct 28, 2022

Conversation

stevenjoezhang
Copy link
Member

No description provided.

@stevenjoezhang stevenjoezhang requested a review from a team October 28, 2022 09:29
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.514% when pulling 9028f91 on ts into 1adb3c6 on master.

yoshinorin
yoshinorin approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Should we release a new version as v5.0.0? or v4.1.0? Which is better?

@stevenjoezhang
Copy link
Member Author

There are no breaking changes, maybe v4.1.0?

@yoshinorin
Copy link
Member

There are no breaking changes, maybe v4.1.0?

Ok. Let's release v4.1.0 after merge this PR!

@stevenjoezhang stevenjoezhang merged commit 1c56d8f into master Oct 28, 2022
@stevenjoezhang stevenjoezhang deleted the ts branch October 28, 2022 15:09
@yoshinorin yoshinorin mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renbaoshuo renbaoshuo renbaoshuo approved these changes

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenjoezhang @coveralls @yoshinorin @renbaoshuo