Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: forEach() #21

Merged
merged 1 commit into from
Oct 19, 2019
Merged

refactor: forEach() #21

merged 1 commit into from
Oct 19, 2019

Conversation

curbengh
Copy link
Contributor

No description provided.

@curbengh curbengh requested a review from segayuu July 31, 2019 07:47
@curbengh
Copy link
Contributor Author

I'm assuming data has >1 keys.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cd65509 on refactor into a1d03e1 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cd65509 on refactor into a1d03e1 on master.

@segayuu segayuu requested review from a team and removed request for segayuu July 31, 2019 10:43
@segayuu
Copy link
Contributor

segayuu commented Jul 31, 2019

hexojs/hexo-i18n#19 (comment)
My personal opinion is all mentioned in the above comments.
Even if you ask the reviewer only for me, PR for conversion purpose to Array#forEach() will not merge.

tcrowe
tcrowe approved these changes Jul 31, 2019
View reviewed changes
Copy link

@tcrowe tcrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NoahDragon NoahDragon merged commit a2fb2ad into master Oct 19, 2019
@curbengh curbengh deleted the refactor branch October 19, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcrowe tcrowe tcrowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@curbengh @coveralls @segayuu @tcrowe @NoahDragon