Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v4.2.0 #129

Merged
merged 1 commit into from
Oct 26, 2023
Merged

release: v4.2.0 #129

merged 1 commit into from
Oct 26, 2023

Conversation

yoshinorin
Copy link
Member

@yoshinorin yoshinorin commented Oct 26, 2023

refs: hexojs/hexo#5326

hexojs/hexo#5326 is a blocking issue for the release of hexo v7.0.0. We should release a new version of hexo-front-matter.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 61b59b1 on yoshinorin:release/v4.2.0 into 63f301a on hexojs:master.

@uiolee uiolee requested review from uiolee and removed request for uiolee October 26, 2023 15:25
@uiolee uiolee marked this pull request as draft October 26, 2023 15:25
@uiolee uiolee marked this pull request as ready for review October 26, 2023 15:25
@uiolee uiolee merged commit 21f72f1 into hexojs:master Oct 26, 2023
@uiolee uiolee linked an issue Oct 29, 2023 that may be closed by this pull request
@yoshinorin yoshinorin deleted the release/v4.2.0 branch October 31, 2023 08:51
@yoshinorin
Copy link
Member Author

Sorry for late action.
Just now I published v4.2.0

https://www.npmjs.com/package/hexo-front-matter/v/4.2.0

Thank you :)

@uiolee
Copy link
Member

uiolee commented Oct 31, 2023

It looks like a wrong version was published to npmjs. The latest code is not reflected in the npm package. Maybe you forgot to exec npm run build?

npmjs

npm

build from latest code

e.g., line 13

git

@yoshinorin
Copy link
Member Author

@uiolee

It looks like you released the wrong version. The latest code is not reflected in the npm package. Maybe you forgot exec npm run build?

Hmm... its strange. The npm run build command always run when exec npm publish. Because, we added prepublish command but it looks like not works.

Anyway, I'll unpublish v4.2.0 and publish v4.2.1 soon.

Thank you :)

@yoshinorin
Copy link
Member Author

Done.

https://www.npmjs.com/package/hexo-front-matter/v/4.2.1


P.S:

I can't unpublish v4.2.0.

$ npm unpublish hexo-front-matter@4.2.0
Authenticate your account at:
https://www.npmjs.com/auth/cli/xxxxxxxxxxxxxxxxxxxxxxxxxx
Press ENTER to open in the browser...

npm ERR! code E405
npm ERR! 405 Method Not Allowed - PUT https://registry.npmjs.org/hexo-front-matter/-rev/42-5115621babe9b15be5a989ffaf5949ef - You can no longer unpublish this package.
npm ERR! Failed criteria:
npm ERR! has dependent packages in the registry
npm ERR!
npm ERR! Please deprecate it instead:
npm ERR! npm deprecate -f 'hexo-front-matter@4.2.0' "this package has been deprecated"
npm ERR! To learn more about our unpublish policies, see https://www.npmjs.com/policies/unpublish

@uiolee
Copy link
Member

uiolee commented Oct 31, 2023

Because, we added prepublish command but it looks like not works.

according to https://docs.npmjs.com/cli/v10/using-npm/scripts#prepare-and-prepublish, prepublish has been deprecated.

@uiolee
Copy link
Member

uiolee commented Oct 31, 2023

thanks.

some limitations on unpublish. you can use deprecate instead.

@yoshinorin
Copy link
Member Author

Because, we added prepublish command but it looks like not works.

We should replace them and specify npm version in engines section.

some limitations on unpublish. you can use deprecate instead.

Thanks. I'll deprecate v4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hexo build failed due to type issue
3 participants