This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Force UTF-8 character coding #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your report and fix. I'll take a look. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation the output encoding depends on the operating systems encoding, for example in Windows it is cp1252 for me. This causes that the generated QR codes cannot be read properly with a lot scanners.
e.g. generating a QR-Code for '…ÄÖÜ' on my Windows PC (uses cp1252) yields '����' with QR Droid (Zapper engine) and '�ﾖﾜ' QR Droid/Barcode Scanner (ZXing engine).
As UTF-8 seems to be the quasi standard among all scanners I tried I'd simply recommend to force using this encoding. With this encoding all scanners I tried did not had any problems with the encoding.