Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autorelabel should be done for permissive SELinux #54

Closed
palonsoro opened this issue Jul 22, 2022 · 3 comments
Closed

Autorelabel should be done for permissive SELinux #54

palonsoro opened this issue Jul 22, 2022 · 3 comments

Comments

@palonsoro
Copy link

On centos specific configuration script, an autorelabel is triggered only if SELinux is configured in enforcing mode[1].

However, it should be also triggered in permissive mode. The reason is that rescue environment does not have SELinux enabled, so the files it creates are unlabeled and remain unlabeled, so permissive mode would report false alerts and, what is worse, there would be failures if enforcing mode is set.

An example of a CentOS version that installs with SELinux set to permissive mode is the Centos Stream 8 version available at the time this issue is being reported.

[1] - https://github.com/hetzneronline/installimage/blob/master/centos.sh#L161

palonsoro added a commit to palonsoro/installimage that referenced this issue Jul 22, 2022
@palonsoro
Copy link
Author

Opened #55 to address this

@palonsoro
Copy link
Author

Any chances this can be reviewed? This should be easy and quick to fix with attached PR.

@palonsoro
Copy link
Author

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant