Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goreleaser): produce OCI manifest images #417

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

samcday
Copy link
Contributor

@samcday samcday commented Apr 6, 2023

No description provided.

@samcday samcday requested a review from a team as a code owner April 6, 2023 15:18
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are flakes.

@samcday samcday merged commit e1152b9 into main Apr 6, 2023
@samcday samcday deleted the manifest-build branch April 6, 2023 15:34
apricote added a commit to hetznercloud/csi-driver that referenced this pull request Apr 11, 2023
apricote added a commit to hetznercloud/csi-driver that referenced this pull request Apr 11, 2023
apricote added a commit to hetznercloud/csi-driver that referenced this pull request Apr 11, 2023
apricote added a commit that referenced this pull request Jul 5, 2023
Since reworking the docker build process in #417 we do not have a
":latest" image to push. The CI pipeline in main has failed since then.

Getting a "latest" image is not that easy with the current goreleaser
setup. We use the goreleaser docker_manifests feature to build
multi-arch images. This stage is not executed in "--snapshot" builds.
apricote added a commit that referenced this pull request Nov 17, 2023
Since reworking the docker build process in #417 we do not have a
":latest" image to push. The CI pipeline in main has failed since then.

Getting a "latest" image is not that easy with the current goreleaser
setup. We use the goreleaser docker_manifests feature to build
multi-arch images. This stage is not executed in "--snapshot" builds.

Example CI failure:
https://github.com/hetznercloud/hcloud-cloud-controller-manager/actions/runs/5461797507/jobs/9940263986
lukasmetzner pushed a commit to hetznercloud/csi-driver that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants