refactor(skaffold): update manifests to match v2+ resources #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v2 we made multiple changes to our deployment manifests that were not mirrored in the skaffold patches for local development: - Remove hcloud token from node - Use Deployment instead of StatefulSet for controller This commit updates the skaffold patches to (better) work with the new version.
With Strategic Merge Patches, it is easier to see which container is actually modified, as they match based on the container name instead of the index. This is also more resilient, as changes to the container order do not break these patches (but container renames do!).
LKaemmerling
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2 we made multiple changes to our deployment manifests that were not
mirrored in the skaffold patches for local development:
This commit updates the skaffold patches to (better) work with the new
version.