-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove custom hook for zerolog #48
Conversation
The logger library already has a defined entry for the hook, I think there is no need to add another one here. |
@rogerogers OK. Then let me remove config.hookFn |
In addition, the implementation of this hook form should reference the implementation of the logrus hook form. Here, overloading of the + hook is executed twice, thus this overloading is unnecessary and should be removed.
|
@rogerogers I have just removed duplicate overloading. |
What type of PR is this?
What this PR does / why we need it (English/Chinese):
Unnecessary.
Which issue(s) this PR fixes:
N/A