Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to retry connecting to egpu on boot for longer than 3 seconds #79

Closed
wants to merge 5 commits into from

Conversation

PlGGS
Copy link

@PlGGS PlGGS commented Jul 3, 2022

I recently discovered that the hit-or-miss connection to my egpu on boot was because egpu-swticher only checks for the egpu bus for three seconds on boot (6 attempts, 2 per second). This wasn't always enough time for my system.

I upped this to 5 seconds by default (5 attempts, 1 per second) and added a setup option for users to customize the amount of attempts egpu-switcher should make to connect to the egpu on boot.

@hertg
Copy link
Owner

hertg commented Jul 16, 2022

Hey, just wanted to let you know that I saw the PR, but wasn't able to look into it in detail yet.
I'm currently thinking about rewriting the script in a language that is easier to maintain for me and I have some time this weekend where I could do that. I will keep you posted.

@hertg
Copy link
Owner

hertg commented Jul 16, 2022

I think it's a great idea to make the amount of retries configurable, but I'm not sure whether we should ask about it in every setup process. Maybe keeping it as an "advanced" configuration to apply in case of issues would be better. I also don't want to make the retry time too long by default, because it will slow down every boot process when there is no egpu attached.

@hertg hertg closed this in d8edb71 Sep 12, 2022
@hertg
Copy link
Owner

hertg commented Sep 12, 2022

@PlGGS
Quick update, my rewrite reached the main branch.
I'm closing this PR, because the code you changed has completely been rewritten.
But I made sure to already include this feature (and a lot of others). If you want to give it a try and give some feedback that would be great.
Please note that when you update to the new version. you'll need to run the config command again.

The amount of retries and interval can be changed via the config, see the new readme for details.

@PlGGS
Copy link
Author

PlGGS commented Sep 13, 2022

Awesome! I meant to respond sooner, thanks for keeping this feature in mind in the rewrite! I really appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants