fix: interactive elements tot responding on mobile #4320
Conversation
🦋 Changeset detectedLatest commit: 7d5f36f The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces a patch for the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
.changeset/wicked-melons-promise.md(1 hunks)packages/hooks/use-aria-button/src/index.ts(0 hunks)
💤 Files with no reviewable changes (1)
- packages/hooks/use-aria-button/src/index.ts
🧰 Additional context used
🪛 LanguageTool
.changeset/wicked-melons-promise.md
[uncategorized] ~5-~5: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...patch --- fix interactive elements tot responding on mobile
(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
🔇 Additional comments (1)
.changeset/wicked-melons-promise.md (1)
1-3: LGTM on the patch version bump
The patch version bump is appropriate for this bug fix addressing mobile interactivity issues, as it doesn't introduce breaking changes.
| "@nextui-org/use-aria-button": patch | ||
| --- | ||
|
|
||
| fix interactive elements tot responding on mobile |
There was a problem hiding this comment.
Fix typo in the changeset description
There's a typo in the description that affects clarity.
Apply this fix:
-fix interactive elements tot responding on mobile
+fix interactive elements not responding on mobile📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| fix interactive elements tot responding on mobile | |
| fix interactive elements not responding on mobile |
🧰 Tools
🪛 LanguageTool
[uncategorized] ~5-~5: This verb may not be in the correct form. Consider using a different form for this context.
Context: ...patch --- fix interactive elements tot responding on mobile
(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)
|
Complete fix here: #4322 |
Closes: #4292
📝 Description
Using onClick to handler the event :
⛳️ Current behavior (updates)
1_1733848569.mp4
🚀 New behavior
3_1733848572.mp4
💣 Is this a breaking change (Yes/No):
📝 Additional Information
This PR also will solve Card component event not work on mobile
Summary by CodeRabbit
Bug Fixes
New Features
allowTextSelectionOnPress, allowing text selection on pressable elements for enhanced functionality.