Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add Scrumbuiss to sponsor section #3496

Merged
merged 4 commits into from
Jul 21, 2024
Merged

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Jul 18, 2024

Closes #

📝 Description

image image image image

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • New Features
    • Introduced a new sponsor, "Scrumbuiss," with its logo to the sponsors section.
    • Enhanced the sponsor retrieval functionality to include sponsors from Patreon, in addition to Open Collective.

Copy link

linear bot commented Jul 18, 2024

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 8c2fec4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 3:22am
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 3:22am

Copy link
Contributor

coderabbitai bot commented Jul 18, 2024

Walkthrough

The changes introduce a new sponsor, "Scrumbuiss," along with its logo into the sponsors section of the documentation. The ScrumbuissLogo component is added and integrated into the sponsors display. Additionally, the getAllSponsors function is updated to include sponsors from Patreon, merging them with existing Open Collective sponsors.

Changes

File Change Summary
apps/docs/components/icons/sponsors.tsx Added a new ScrumbuissLogo component containing SVG paths for the logo.
apps/docs/components/marketing/sponsors.tsx Included the ScrumbuissLogo alongside other sponsor logos and added "Scrumbuiss" to the sponsors section.
apps/docs/utils/get-all-sponsors.ts Updated getAllSponsors to fetch and merge sponsors from Patreon and Open Collective.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DocsComponent as Documentation Component
    participant GetSponsors as getAllSponsors

    User->>DocsComponent: Access Sponsors Section
    DocsComponent->>GetSponsors: Fetch Sponsors List
    GetSponsors->>OpenCollective: Fetch Open Collective Sponsors
    GetSponsors->>Patreon: Fetch Patreon Sponsors
    GetSponsors->>DocsComponent: Return Merged Sponsors List
    DocsComponent->>User: Display Sponsors including Scrumbuiss
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (2)
apps/docs/components/icons/sponsors.tsx (2)

114-117: Inconsistent attributes in ScrumbuissLogo component.

The ScrumbuissLogo component does not maintain consistency with other logo components in terms of attributes and style. Specifically:

  • Width and Height: ScrumbuissLogo uses fixed width (200px) and height (35px), whereas other logos use dynamic properties with default values (e.g., width={width} and height={height}).
  • Additional Props: Other logos spread additional props (...props) into the <svg> element, which ScrumbuissLogo does not.

To maintain consistency, consider updating ScrumbuissLogo to use dynamic properties and spread additional props.

  • RelumeLogo: {width = 152, height = 56, ...props}
  • Story2DesignLogo: {width = 175, height = 26, ...props}
  • ReplexicaLogo: className="text-black dark:text-white" fill="none" height="30" viewBox="0 0 442 86" xmlns="http://www.w3.org/2000/svg" {...props}
  • CodeRabbitLogo: fill="none" height="30" viewBox="0 0 9599 1799" xmlns="http://www.w3.org/2000/svg"
Analysis chain

Maintain consistency with other logo components.

Ensure that the ScrumbuissLogo component is consistent with other logo components in terms of style, size, and attributes.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistency of the `ScrumbuissLogo` component with other logo components.

# Test: Compare the `ScrumbuissLogo` component with other logo components in the same file. Expect: Consistent style, size, and attributes.
rg --type tsx 'Logo' apps/docs/components/icons/sponsors.tsx

Length of output: 88


Script:

#!/bin/bash
# Description: Verify consistency of the `ScrumbuissLogo` component with other logo components.

# Test: Compare the `ScrumbuissLogo` component with other logo components in the same file. Expect: Consistent style, size, and attributes.
rg 'Logo' apps/docs/components/icons/sponsors.tsx -A 10

Length of output: 38920


114-117: The SVG structure in ScrumbuissLogo has issues.

  • The xmlns attribute is missing in the <svg> tag. This attribute is crucial for the SVG to be correctly rendered.
  • No <path> elements were found in the SVG. Ensure that the SVG paths are correctly defined.

Please address these issues to ensure the SVG renders correctly.

Analysis chain

Ensure the SVG structure is correct.

The SVG structure appears to be correct and well-formed. Ensure that the SVG paths and attributes are accurate and render as expected.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness of the SVG structure in `ScrumbuissLogo`.

# Test: Render the SVG to check for any visual issues. Expect: SVG renders correctly without errors.
# Note: This is a manual step, ensure to visually inspect the rendered SVG.
echo "Please visually inspect the rendered SVG for correctness."

Length of output: 124


Script:

#!/bin/bash
# Description: Verify the correctness of the SVG structure in `ScrumbuissLogo`.

# Check for common SVG issues such as missing or incorrect attributes.
# Search for the `ScrumbuissLogo` function definition and extract the SVG content.
ast-grep --lang typescript --pattern $'export const ScrumbuissLogo = () => (
  <svg $_>
    $$$
  </svg>
)' --json | jq -r '.[0].matches[0].text' > scrumbuissLogo.svg

# Validate the SVG file using `xmllint` to check for well-formedness.
if xmllint --noout scrumbuissLogo.svg; then
  echo "SVG structure is well-formed."
else
  echo "SVG structure has issues."
fi

# Clean up
rm scrumbuissLogo.svg

Length of output: 344


Script:

#!/bin/bash
# Description: Verify the correctness of the SVG structure in `ScrumbuissLogo`.

# Check for common SVG issues such as missing or incorrect attributes.
# Search for the `ScrumbuissLogo` function definition and extract the SVG content.
ast-grep --lang typescript --pattern $'export const ScrumbuissLogo = () => (
  <svg $_>
    $$$
  </svg>
)' --json | jq -r '.[0].matches[0].text' > scrumbuissLogo.svg

# Check for common SVG issues using grep
if grep -Eq '<svg[^>]* xmlns="http://www.w3.org/2000/svg"[^>]*>' scrumbuissLogo.svg && \
   grep -Eq '<path[^>]*>' scrumbuissLogo.svg; then
  echo "SVG structure appears to be correct."
else
  echo "SVG structure has issues."
fi

# Clean up
rm scrumbuissLogo.svg

Length of output: 314


Script:

#!/bin/bash
# Description: Verify the SVG structure in `ScrumbuissLogo` by extracting and analyzing its content.

# Extract the SVG content from the `ScrumbuissLogo` function.
ast-grep --lang typescript --pattern $'export const ScrumbuissLogo = () => (
  <svg $_>
    $$$
  </svg>
)' --json | jq -r '.[0].matches[0].text' > scrumbuissLogo.svg

# Check for the presence of the xmlns attribute in the <svg> tag
if grep -q '<svg' scrumbuissLogo.svg && grep -q 'xmlns="http://www.w3.org/2000/svg"' scrumbuissLogo.svg; then
  echo "xmlns attribute is present in the <svg> tag."
else
  echo "xmlns attribute is missing in the <svg> tag."
fi

# Check for the presence of <path> elements
if grep -q '<path' scrumbuissLogo.svg; then
  echo "<path> elements are present in the SVG."
else
  echo "No <path> elements found in the SVG."
fi

# Clean up
rm scrumbuissLogo.svg

Length of output: 425

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a30edbb and 8c2fec4.

Files selected for processing (3)
  • apps/docs/components/icons/sponsors.tsx (1 hunks)
  • apps/docs/components/marketing/sponsors.tsx (2 hunks)
  • apps/docs/utils/get-all-sponsors.ts (1 hunks)
Additional comments not posted (4)
apps/docs/utils/get-all-sponsors.ts (2)

23-23: LGTM!

The code changes are approved.


9-21: Ensure the existence and validity of .sponsorsrc.

Make sure that the .sponsorsrc file exists and contains valid JSON data to avoid runtime errors.

apps/docs/components/marketing/sponsors.tsx (2)

25-29: LGTM!

The code changes are approved.


4-4: Verify the existence of ScrumbuissLogo.

Ensure that the ScrumbuissLogo component exists and is correctly imported.

Verification successful

Verified the existence of ScrumbuissLogo.

The ScrumbuissLogo component exists and is correctly imported and used in the codebase.

  • apps/docs/components/icons/sponsors.tsx: export const ScrumbuissLogo = () => (
  • apps/docs/components/marketing/sponsors.tsx: import {Story2DesignLogo, ReplexicaLogo, CodeRabbitLogo, ScrumbuissLogo} from "@/components/icons/sponsors";
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of `ScrumbuissLogo` component.

# Test: Search for the `ScrumbuissLogo` component. Expect: Component should exist.
fd --type f --name "ScrumbuissLogo.*"

Length of output: 290


Script:

#!/bin/bash
# Description: Verify the existence of `ScrumbuissLogo` component.

# Test: Search for the `ScrumbuissLogo` component. Expect: Component should exist.
fd 'ScrumbuissLogo'

Length of output: 19


Script:

#!/bin/bash
# Description: Verify the existence of `ScrumbuissLogo` component.

# Test: Search for the `ScrumbuissLogo` component within the codebase. Expect: Component should exist.
rg 'ScrumbuissLogo'

Length of output: 324

apps/docs/components/icons/sponsors.tsx Show resolved Hide resolved
@jrgarciadev jrgarciadev merged commit fe62bfb into main Jul 21, 2024
3 checks passed
@jrgarciadev jrgarciadev deleted the feat/eng-1151 branch July 21, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants