-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add peer dependencies #1651
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@syi0808 is attempting to deploy a commit to the NextUI Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you! @syi0808
I didn't update pnpm lock. Sorry. Update within 30 minutes |
📝 Description
Looking for a little more, the peer dependency of the package used by next-ui was not declared as the peer dependency of next-ui.
The following solutions are being used temporarily.
Change peer dependency forced injection or pnpFallbackMode: "all" using packageExtensions option in yarnrc.yml
It is enough for me already, but I made a PR because I thought it would be nice if a more fundamental solution could be prepared in next-ui.
⛳️ Current behavior (updates)
Module not found because peer dependency does not have react-dom and framer-motion in nextui packages. (only yarn PnP , not node_modules)
🚀 New behavior
Add as peer dependency to packages requiring react-dom or framer-motion.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information