Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add peer dependencies #1651

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Conversation

syi0808
Copy link
Contributor

@syi0808 syi0808 commented Sep 18, 2023

📝 Description

Screenshot 2023-09-18 at 2 31 19 PM I encountered an error starting a new Next 13 project. This was a problem with yarn PnP and there was no similar case. As a result of analyzing the error, it was an error that the react-dom package could not be found in the react-aria/overlay package.

Looking for a little more, the peer dependency of the package used by next-ui was not declared as the peer dependency of next-ui.

The following solutions are being used temporarily.

Change peer dependency forced injection or pnpFallbackMode: "all" using packageExtensions option in yarnrc.yml

It is enough for me already, but I made a PR because I thought it would be nice if a more fundamental solution could be prepared in next-ui.

⛳️ Current behavior (updates)

Module not found because peer dependency does not have react-dom and framer-motion in nextui packages. (only yarn PnP , not node_modules)

🚀 New behavior

Add as peer dependency to packages requiring react-dom or framer-motion.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

⚠️ No Changeset found

Latest commit: 01873b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 2:43pm

@vercel
Copy link

vercel bot commented Sep 18, 2023

@syi0808 is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you! @syi0808

@syi0808
Copy link
Contributor Author

syi0808 commented Sep 22, 2023

I didn't update pnpm lock. Sorry. Update within 30 minutes

@jrgarciadev jrgarciadev linked an issue Sep 23, 2023 that may be closed by this pull request
@jrgarciadev jrgarciadev merged commit 9ebaae0 into heroui-inc:main Sep 23, 2023
@jrgarciadev jrgarciadev linked an issue Oct 4, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Missing peer dependencies [BUG] - provide or delegate peer dependencies
2 participants