Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heroku go to v5 #211

Merged
merged 5 commits into from
Jul 11, 2019
Merged

Update heroku go to v5 #211

merged 5 commits into from
Jul 11, 2019

Conversation

davidji99
Copy link
Collaborator

Basically a clone of #196.

@ghost ghost added the size/XXL label Jun 27, 2019
@davidji99
Copy link
Collaborator Author

davidji99 commented Jun 27, 2019

Hi @mars,

Please review. I have a dependency on the provider using heroku-go v5 so I cherry-picked your 6c6cb76 and ran go mod tidy and go mod vendor again.

@mars
Copy link
Member

mars commented Jun 27, 2019

Looks good @davidji99 😄 Thanks for taking care of this!

I just started a Hashicorp CI run ⏳Will report back.

@mars
Copy link
Member

mars commented Jun 27, 2019

Hashicorp CI ran out of Private Spaces, so I’ll have to clean-up the cruft & re-run later this morning.

@mars
Copy link
Member

mars commented Jun 27, 2019

The CI run failed 1 test 🙅‍♂️

------- Stdout: -------
=== RUN   TestAccDatasourceHerokuApp_Basic
--- FAIL: TestAccDatasourceHerokuApp_Basic (10.54s)
    testing.go:538: Step 1 error: Check failed: Check 7/9 error: data.heroku_app.foobar: Attribute 'buildpacks.0' expected "https://github.com/heroku/heroku-buildpack-multi-procfile", got "heroku/go"
FAIL

@davidji99
Copy link
Collaborator Author

The CI run failed 1 test 🙅‍♂️

------- Stdout: -------
=== RUN   TestAccDatasourceHerokuApp_Basic
--- FAIL: TestAccDatasourceHerokuApp_Basic (10.54s)
    testing.go:538: Step 1 error: Check failed: Check 7/9 error: data.heroku_app.foobar: Attribute 'buildpacks.0' expected "https://github.com/heroku/heroku-buildpack-multi-procfile", got "heroku/go"
FAIL

Thanks will take a look.

@davidji99 davidji99 force-pushed the update-heroku-go-to-v5 branch 2 times, most recently from 933b47a to 022e515 Compare July 10, 2019 01:37
@davidji99
Copy link
Collaborator Author

@mars Will you run the full suite again? I updated this branch to use heroku-go v5.1.0.

@mars
Copy link
Member

mars commented Jul 10, 2019

Running the suite now 🏃‍♂️

@davidji99
Copy link
Collaborator Author

Thanks!

@mars
Copy link
Member

mars commented Jul 11, 2019

After some normal flakiness, the Hashicorp CI passed for this PR ✅

@mars mars merged commit faddbbf into master Jul 11, 2019
@davidji99 davidji99 deleted the update-heroku-go-to-v5 branch May 28, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants