Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a heroku_team_member resource for managing members of a Heroku team #121

Merged
merged 6 commits into from
Sep 10, 2018

Conversation

joestump
Copy link
Contributor

@joestump joestump commented Aug 30, 2018

Tested with the following HCL:

provider "heroku" {}

resource "heroku_team_member" "joe_test" {
  team  = "team-name"
  email = "someone@example.com"
  role  = "viewer"
}

@ghost ghost added the size/L label Aug 30, 2018
Federated: &federated,
}

_, err := client.TeamMemberCreateOrUpdate(context.TODO(), d.Get("team").(string), opts)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the team you defined above at L65?

```hcl
# Adds a Heroku user to a Heroku team as a viewer.
resource "heroku_team_member" "foobar-member" {
team = "${heroku_app.foobar.name}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here?

Team members can be imported using the combination of the team application name, a colon, and the member's email address.

```
$ terraform import heroku_team_member.foobar-member foobar_app:some-user@example.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here? Or are you implying app == team?

@davidji99
Copy link
Collaborator

Can you add an import resource test?

@davidji99 davidji99 merged commit a1140a3 into master Sep 10, 2018
@davidji99 davidji99 deleted the jstump-team-member-resource branch September 10, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants