Fail detection with a CNB-friendly exit code #1111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
approved these changes
Jan 19, 2021
|
Thanks. I've grabbed your commit so that I can run the tests against it. PR to the test branch is linked. It's conditionally approved pending tests passing. |
|
Tests passed and your change has been merged (though not yet deployed). Thanks for the contribution! |
|
Great! Thanks, @schneems 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CNB spec defines the following exit codes for detection scripts:
0- passed detection100- failed detection(ref: https://github.com/buildpacks/spec/blob/main/buildpack.md#detection)
My understanding is that this change is in-line with the Heroku Buildpack API, but let me know if that's not the case.