Commits on Jan 15, 2021

1. Fail the build if apt-get or curl errors …

   Enables the bash `pipefail` mode, which ensures that a failure in a
   command prior to a pipe correctly causes the script to exit 1.
   
   Without this, failures during the `apt-get` and `curl` invocations were
   ignored and the compile marked as a success. At best this leads to
   confusing errors in later buildpacks (if build time dependencies are
   missing), and at worst this could cause runtime failures for packages
   not used during the build, but required by the app at runtime.
   
   Enabling `pipefail` mode required a change to the custom repositories
   feature, to prevent the build exiting 1 when `grep -s -e "^:repo:"`
   found no matches (ie when no custom repositories are specified).
   
   In addition, the `--show-error` and `--fail` flags have been added to
   the `curl` call, otherwise non-HTTP 200 exit codes are ignored and the
   compile similarly marked as successful when it should not have been.
   
   Fixes #47.
   Fixes W-8722791.

   

   edmorley committed Jan 15, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 0803401
   • Browse repository at this point

   Copy the full SHA

   0803401 View commit details

   Browse the repository at this point in the history