Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent APT using source lists from /etc/apt/sources.list.d/ #46

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Prevent APT using source lists from /etc/apt/sources.list.d/ #46

merged 2 commits into from
Jun 11, 2019

Commits on Jun 10, 2019

  1. Prevent APT using source lists from /etc/apt/sources.list.d/ 

    Previously the buildpack only passed `-o dir::etc::sourcelist` to APT,
which meant that APT still used the default `sourceparts` location of
`/etc/apt/sources.list.d/`.

This meant on cedar-14 this buildpack would use esm.ubuntu.com as an APT
source (as of heroku/base-images/pull/140), which results in errors if
the requested packages happened to have ESM-only updates available
(since the ESM repository requires credentials since it's a paid Ubuntu
offering).

Fixes #45 / W-6224944.
    @edmorley
    edmorley committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    0beae64 View commit details
    Browse the repository at this point in the history

  2. Use /dev/null instead 

    Since whilst `-` appears to work, `/dev/null` is what is referenced here:
https://salsa.debian.org/apt-team/apt/blob/f15e090301e0744471d0fbf86ea0d494f6c08215/apt-pkg/sourcelist.cc#L313
    @edmorley
    edmorley committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    723318e View commit details
    Browse the repository at this point in the history