Remove Heroku support links on errors #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
force-pushed
the
malax/remove-heroku-support-links
branch
from
0b0ac15
to
48c27c0
Compare
Malax
force-pushed
the
malax/remove-heroku-support-links
branch
from
48c27c0
to
7778ae9
Compare
edmorley
approved these changes
May 24, 2024
This was referenced May 28, 2024
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
May 28, 2024
## heroku/gradle ### Changed - Some error messages have changed so they longer suggest to open a Heroku support ticket. Instead, users are now provided with a link to create an issue on GitHub. ([#674](heroku/buildpacks-jvm#674)) ## heroku/java ### Changed - Updated `heroku/gradle` to `6.0.0`. - Updated `heroku/jvm` to `6.0.0`. - Updated `heroku/maven` to `6.0.0`. ## heroku/java-function ### Changed - Updated `heroku/jvm-function-invoker` to `6.0.0`. - Updated `heroku/jvm` to `6.0.0`. - Updated `heroku/maven` to `6.0.0`. ## heroku/jvm ### Added - Checksum validation of downloaded OpenJDK distribution files. ([#680](heroku/buildpacks-jvm#680)) - A warning will now be shown when the OpenJDK version is not explicitly configured for an application. ([#681](heroku/buildpacks-jvm#681)) ### Changed - This buildpack now installs the latest long-term support release (currently 21) of OpenJDK if no version is explicitly configured. Previously, OpenJDK 8 was installed as the default. ([#681](heroku/buildpacks-jvm#681)) - Some error messages have changed so they longer suggest to open a Heroku support ticket. Instead, users are now provided with a link to create an issue on GitHub. ([#674](heroku/buildpacks-jvm#674)) ### Removed - The buildpack no longer installs [Heroku's Java Metrics Agent](https://github.com/heroku/heroku-java-metrics-agent). It is only useful on the Heroku platform and can be installed by a dedicated buildpack in the future. ([#679](heroku/buildpacks-jvm#679)) ## heroku/jvm-function-invoker - No changes. ## heroku/maven ### Changed - Some error messages have changed so they longer suggest to open a Heroku support ticket. Instead, users are now provided with a link to create an issue on GitHub. ([#674](heroku/buildpacks-jvm#674)) ## heroku/sbt ### Changed - Some error messages have changed so they longer suggest to open a Heroku support ticket. Instead, users are now provided with a link to create an issue on GitHub. ([#674](heroku/buildpacks-jvm#674)) ## heroku/scala ### Changed - Updated `heroku/jvm` to `6.0.0`. - Updated `heroku/sbt` to `6.0.0`. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some error messages suggest to open a Heroku support ticket. This behaviour was inherited from the existing Heroku buildpacks.
However, this doesn't make sense for our CNBs as they are not specific to the Heroku platform and can be used outside of it. Instead, users should open an issue on GitHub if they encounter a problem they need help with.
Otherwise, this PR does not change the error messages. I want to streamline errors between JVM buildpacks as well as adding stricter tests for them. But this is not the PR for that.