add libm support #37
Merged
add libm support #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libm is port of MUSL's libm to Rust. Use this crate to support basic arithmetic functions.
jschwe
reviewed
Jun 5, 2020
| let z: f64 = y.log(E); | ||
|
|
||
| println!("x = {}, e^x = {}, ln(e^x) = {}", x, y, z); | ||
|
|
||
| Ok(()) |
There was a problem hiding this comment.
Maybe add a check here if x and z are approximately the same instead of always returning Ok(())
jschwe
reviewed
Jun 9, 2020
| libm::atan2(a, b) | ||
| } | ||
|
|
||
| pub extern "C" fn atan2f(a: f32, b: f32) -> f32 { |
There was a problem hiding this comment.
I think #[no_mangle] is missing here
There was a problem hiding this comment.
Yes, I revise the PR
jschwe
reviewed
Jun 9, 2020
hermit-sys/src/cmath.rs
Outdated
| libm::log(x) | ||
| } | ||
|
|
||
| pub fn logf(x: f32) -> f32 { |
There was a problem hiding this comment.
Is this one intentionally a rust function?
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 13, 2023
Hermit: Remove floor symbol This symbol should be provided by Hermit. It was introduced in 2019 (rust-lang#65167). Since 2020, Hermit provides these math functions on its own (hermit-os/hermit-rs#37). I think moving this to Hermit was merely an oversight. Related: * hermit-os/kernel#654 * hermit-os/hermit-rs#406 CC: `@stlankes`
thomcc
pushed a commit
to tcdi/postgrestd
that referenced
this pull request
May 31, 2023
Hermit: Remove floor symbol This symbol should be provided by Hermit. It was introduced in 2019 (rust-lang/rust#65167). Since 2020, Hermit provides these math functions on its own (hermit-os/hermit-rs#37). I think moving this to Hermit was merely an oversight. Related: * hermit-os/kernel#654 * hermit-os/hermit-rs#406 CC: `@stlankes`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libm is port of MUSL's libm to Rust. This crate is used to support basic arithmetic functions.