Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for http proxy #21

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Add support for http proxy #21

merged 6 commits into from
Nov 2, 2023

Conversation

jirihnidek
Copy link
Contributor

  • When http proxy is used, then print information about using proxy server and URL of this server. This is printed only in situation, when proxy server is really used for sending given HTTP request.

@jirihnidek
Add support for http proxy
346c3f6 
* When http proxy is used, then print information about
  using proxy server and URL of this server. This is
  printed only in situation, when proxy server is really
  used for sending given HTTP request.
@jirihnidek
Copy link
Contributor Author

I also tried to write some unit test for this new functionality, but it seems too complicated. If unit test will be required, then I can try it once again.

@henvic
Copy link
Owner

henvic commented Oct 30, 2023

Hi @jirihnidek, I missed your notification and just noticed it now. I'm going to try to add tests and if everything looks good, I'll probably merge it tonight.

@henvic henvic merged commit 8ccaa9c into henvic:main Nov 2, 2023
8 checks passed
@jirihnidek
Copy link
Contributor Author

Cool. Thanks for merging the PR. 👍

@jirihnidek jirihnidek deleted the http_proxy branch November 2, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirihnidek @henvic