Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single vs. double precision #19

Open
henry2004y opened this issue Jul 25, 2021 · 1 comment
Open

Single vs. double precision #19

henry2004y opened this issue Jul 25, 2021 · 1 comment

Comments

@henry2004y
Copy link
Owner

In previous versions, I maintain the original double precision DCCRG grid variables while converting all FS grid variables to single precision. Maybe we should use single precision consistently in postprocessing and visualization, as it makes less sense to use double precision for data analysis.
henry2004y added a commit that referenced this issue Jul 25, 2021
@henry2004y
Use Float32 in VTK conversion
8566f1e 
Handle #19; Bump minor version
@henry2004y
Copy link
Owner Author

When performing the really sensitive linear MHD wave tests, the effect of force converting to single precision shows up:

Force converting to single:

alfven_1d_single_vs_double_A1e-6_n25

Maintaining original double precision:

alfven_1d_single_vs_double_A1e-6_n25_alldouble_output

Should I provide an option for keeping the double precision values?

@henry2004y henry2004y reopened this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henry2004y