-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix function calling for streaming #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@akshaylb can you please add an example as |
@akshaylb any news on this? |
Apologies for the delay @henomis |
henomis
requested changes
Apr 10, 2024
henomis
requested changes
Apr 12, 2024
henomis
requested changes
Apr 13, 2024
henomis
requested changes
Apr 19, 2024
@akshaylb just a couple of changes for the final review, then we'll merge it. |
Co-authored-by: Simone Vellei <henomis@gmail.com>
@henomis changes completed. |
henomis
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
When using the streaming option with a tool binding, openAI returns function arguments in separate chunked responses.
The current implementation assumed all function arguments are returned in one response and thus the function call kept failing due to it not satisfying the json schema requirements.
Fixes #168
allToolCalls
andcurrentToolCall
to concatenate the incoming function response arguments, only terminating once a new function call with a new unique id comes in the request or theEOS
is hit.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: