Feature - null value handling #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsteinkopf
requested changes
May 8, 2023
|
Alright, I gave my best to refactor the codebase. I cannot test the code on an actual device until Wednesday. But maybe there are still some changes left :) Let's see |
dsteinkopf
requested changes
May 18, 2023
|
Please review the changes. I've tested this version on my "dev device". Also, I fixed a typo in the config which will be a breaking change (magAge...) instead of (maxAge...) . Furthermore, I change the readConfig section to allow default values, reducing the config file havely. I mean there are only a few lines necessary now to run the service. |
dsteinkopf
reviewed
May 28, 2023
henne49
approved these changes
Jun 19, 2023
henne49
approved these changes
Jun 19, 2023
Small improvements, typos etc.
dsteinkopf
approved these changes
Jun 21, 2023
This was
linked to
issues
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
untested on a real device but should resolve issue #72
Please review what I did and let's discuss if you don't like it. Furthermore, I introduce unit tests in our codebase and implement full coverage for the helpers.py which I also used to test this issue.