-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ahoy API change by Ahoy version 0.5.93 and above #65
Conversation
@henne49 @GallusMax Could try this branch on your systems? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor changes required
refactor to have seperate modules instead of one big module add timing for fetch_url load OpenDTU test data from docs add constants
logging.warning(f"Recovered inverter {self.pvinverternumber} ({self._get_name()}): " | ||
f"Successfully fetched data now: {'NOT' if not self.is_data_up2date() else 'Is'} up-to-date") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich würde sagen, hier ist eindeutig kein Passwort im Spiel. @henne49 stimmt's?
) # id assigned by Victron Support from SDM630v2.py | ||
self._dbusservice.add_path("/ProductName", productname) | ||
self._dbusservice.add_path("/CustomName", self._get_name()) | ||
logging.info(f"Name of Inverters found: {self._get_name()}") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich würde sagen, hier ist eindeutig kein Passwort im Spiel. @henne49 stimmt's?
self._dbusservice[pre + "/Energy/Forward"] = pvyield | ||
self._dbusservice["/Ac/Energy/Forward"] = pvyield | ||
|
||
logging.debug("Inverter #%d Power (/Ac/Power): %s", self.pvinverternumber, power) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich würde sagen, hier ist eindeutig kein Passwort im Spiel. @henne49 stimmt's?
self._dbusservice["/Ac/Energy/Forward"] = pvyield | ||
|
||
logging.debug("Inverter #%d Power (/Ac/Power): %s", self.pvinverternumber, power) | ||
logging.debug("Inverter #%d Energy (/Ac/Energy/Forward): %s", self.pvinverternumber, pvyield) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich würde sagen, hier ist eindeutig kein Passwort im Spiel. @henne49 stimmt's?
self.last_update_successful = True | ||
else: | ||
# It happens that this warning appears without an Exception being logged above. Why? | ||
logging.warning(f"Error while processing inverter {self.pvinverternumber} ({self._get_name()})") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
see Test data from #54
Ahoi API implementation source: https://github.com/lumapu/ahoy/blob/main/src/web/RestApi.h