Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dbus-opendtu.py #28

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Update dbus-opendtu.py #28

merged 1 commit into from
Feb 15, 2023

Conversation

turbolift
Copy link
Contributor

FIX: 3b7aef6 2023-02-13 BREAKING CHANGE: Web API!

@turbolift
Update dbus-opendtu.py
1a03c3f 
FIX: 3b7aef6       2023-02-13      BREAKING CHANGE: Web API!
henne49
henne49 requested changes Feb 15, 2023
View reviewed changes
Copy link
Owner

@henne49 henne49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the change, can we implement to check for both the old way and the new way please? As we can not use a version from XML it would be good enough to use try and except for now, as I have no better idea yet.

henne49
henne49 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Owner

@henne49 henne49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users should upgrade to the newest version. Will only allow newest openDTU

@henne49 henne49 merged commit e0f76bd into henne49:main Feb 15, 2023
@henne49 henne49 mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henne49 henne49 henne49 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolift @henne49