Testcases for template #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x7878
approved these changes
May 27, 2024
| @@ -171,10 +171,10 @@ def _get_config(): | |||
| return config | |||
|
|
|||
| @staticmethod | |||
| def get_processed_meter_value(meter_data: dict, value: str, default_value: any, factor: int = 1) -> any: | |||
| def get_processed_meter_value(meter_data: dict, path_to_value, default_value: any, factor: int = 1) -> any: | |||
There was a problem hiding this comment.
Why did you remove the type?
Suggested change
| def get_processed_meter_value(meter_data: dict, path_to_value, default_value: any, factor: int = 1) -> any: | |
| def get_processed_meter_value(meter_data: dict, path_to_value: str, default_value: any, factor: int = 1) -> any: |
There was a problem hiding this comment.
because this is actually not a string - it is an array of strings. But not always... So the "str" here is more confusing than helping
We should clean this up...
| @@ -484,7 +484,7 @@ def fetch_url(self, url, try_number=1): | |||
| else: | |||
| raise | |||
|
|
|||
| def _get_data(self): | |||
| def _get_data(self) -> dict: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests for template and add docu for path in json