Specify number of inverters in config.ini #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added config parameter to specify amount of computed inverters
henne49
reviewed
Feb 21, 2024
config.ini
Outdated
| @@ -34,6 +34,10 @@ HTTPTimeout=2.5 | |||
| Username = | |||
| Password = | |||
|
|
|||
| # Number of inverters if not all from json response should be used | |||
There was a problem hiding this comment.
Move it up to line 10, also call it differently to show, that we query only the first amount X of devices. QueryOnlyFirstOfDTUInverter
Comment should be like: If you want to exclude Inverter, specify how many of the Inverters you want to query. Please assure that the order is correct in the DTU, we can only extract the first one in a row.
Please also update the README page
Changed config value name. Updated comments and Readme.md.
0x7878
requested changes
Feb 22, 2024
README.md
Outdated
| @@ -89,7 +89,8 @@ Within the project there is a file `/data/dbus-opendtu/config.ini`. Most importa | |||
| |-------------------- | ------------- | | |||
| | SignOfLifeLog | Time in minutes how often a status is added to the log-file `current.log` with log-level INFO | | |||
| | NumberOfTemplates | Number ob Template Inverter to query | | |||
| | DTU | Which DTU to be used ahoy, opendtu or template REST devices Valid options: opendtu, ahoy, template | | |||
| | DTU | Which DTU to be used ahoy, opendtu or template REST devices Valid options: opendtu, ahoy, template | | |||
| | QueryOnlyFirstOfDTUInverter | Amount of Inverters you to query. Set a value larger than "0" when not all inverters should be considered. Please assure that the order is correct in the DTU, we can only extract the first one in a row. | | |||
There was a problem hiding this comment.
Suggested change
| | QueryOnlyFirstOfDTUInverter | Amount of Inverters you to query. Set a value larger than "0" when not all inverters should be considered. Please assure that the order is correct in the DTU, we can only extract the first one in a row. | | |
| | QueryOnlyFirstOfDTUInverter | Number of inverters you want to query. if you want to query all inverters, set this to 0. Please make sure that the order in the DTU is correct, we can only extract the first one in a row. | |
The text is quite long, maybe it can be shortened and the rest could be in a footnote. See Footnotes
Revised Readme and parameter name
Footnotes don't seem to work
Adopted style
0x7878
approved these changes
Feb 22, 2024
| @@ -89,7 +89,8 @@ Within the project there is a file `/data/dbus-opendtu/config.ini`. Most importa | |||
| |-------------------- | ------------- | | |||
| | SignOfLifeLog | Time in minutes how often a status is added to the log-file `current.log` with log-level INFO | | |||
| | NumberOfTemplates | Number ob Template Inverter to query | | |||
| | DTU | Which DTU to be used ahoy, opendtu or template REST devices Valid options: opendtu, ahoy, template | | |||
| | DTU | Which DTU to be used ahoy, opendtu or template REST devices Valid options: opendtu, ahoy, template | | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all I wan't to thank for the great work and valueable project. Well done!
In my case I have a lot of inverters defined in OpenDTU but not all of them should be forwarded to Venus OS.
My apporach is to define the amount of inverters in the config.ini file which should be forwarded.
It is totally backward compatible with the current solution as a value of 0 extracts the amount from the JSON response.
Another, but more complex solution, is to add an additional parameter to the inverter section with the advantage that the inverters to be taken into account do not necessarily have to be at the beginning.
A discussion about that is appreciated.