openDTU v24.2.12 breaking change - code fix #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsteinkopf
requested changes
Feb 19, 2024
|
Ich würde mich @dsteinkopf anschließen. Sieht für mich ansonsten gut aus. Eine Frage: Wollen wir die logger.debug aufrufe drin lassen? |
0x7878
approved these changes
Feb 19, 2024
Ich bin dafür? Hier ist alles nicht sehr performance-kritisch. Läuft ja alles nur alle paar Sekunden. Es wäre evtl. anders, wenn das x-mal pro Sekunde läuft. |
Ja die debug logs sollten wieder raus, die waren eigentloich nur für mich und sind jetzt raus |
dsteinkopf
approved these changes
Feb 19, 2024
| else: | ||
| pvyield = root_meter_data["AC"]["0"]["YieldTotal"]["v"] | ||
| pvyield = root_meter_data[field_inv]["0"]["YieldTotal"]["v"] |
There was a problem hiding this comment.
Vielleicht noch so ein "if" für die Yield-Feldnamen? Wie Du meinst...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.