Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serial number retrieval and add power #124

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Fix serial number retrieval and add power #124

merged 2 commits into from
Nov 20, 2023

Conversation

0x7878
Copy link
Collaborator

@0x7878 0x7878 commented Nov 14, 2023

measurement for Ahoy variant by @
c-graeser

@c-graeser Please test this again on your hardware

@0x7878
Fix serial number retrieval and add power
09d2280 
measurement for Ahoy variant

Co-authored-by: c-graeser <>
c-graeser
c-graeser suggested changes Nov 14, 2023
View reviewed changes
Copy link

@c-graeser c-graeser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zeile 280 muss bündig mit dem darüber liegenden "if..." beginnen:

   if self.dtuvariant....
         raise .....
   serial =.....

Zeile 655 kann der Kommentar mit GCG auch entfernt werden

@0x7878
Fix indent; remove comment
4c6a711 
Co-authored-by: c-graeser < >
@0x7878
Copy link
Collaborator Author

0x7878 commented Nov 20, 2023 •
edited
Loading

Sorry war berufsbedingt stark eingebunden. Ich denke, jetzt haben wir's 😃

@henne49 henne49 merged commit 5e96038 into main Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henne49 henne49 henne49 approved these changes

@c-graeser c-graeser c-graeser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x7878 @henne49 @c-graeser