Improvement on shell script log per service & uninstall (#210)

* run on fork codeql and pylint

* use service name for /var/log folder

* remove the whole service directory

* fix typo

* break while loop

* service removal, check for directory delete link

service/log/run

@@ -1,4 +1,8 @@
 #!/bin/sh
 exec 2>&1
+#Script Directory
+SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
+SCRIPT_DIR=$(realpath $SCRIPT_DIR/../../)
+SERVICE_NAME=$(basename $SCRIPT_DIR)
 # documentation on how to use multilog https://manpages.debian.org/stretch/daemontools/multilog.8.en.html
-exec multilog t s153600 n2 /var/log/dbus-opendtu
+exec multilog t s153600 n2 /var/log/${SERVICE_NAME}

uninstall.sh

@@ -1,10 +1,13 @@
 #!/bin/bash
 SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 SERVICE_NAME=$(basename $SCRIPT_DIR)
+LOG_DIR=/var/log/$SERVICE_NAME
 RC_LOCAL_FILE=/data/rc.local
 
 #remove the service
-rm /service/$SERVICE_NAME
+if [ -d /service/$SERVICE_NAME ]; then  
+    rm /service/$SERVICE_NAME
+fi 
 
 # end the dbus-opendtu process
 kill $(pgrep -f "python $SCRIPT_DIR/dbus-opendtu.py")
@@ -16,4 +19,16 @@ fi
 
 # remove install.sh from rc.local
 STARTUP=$SCRIPT_DIR/install.sh
-sed -i "\~$STARTUP~d" $RC_LOCAL_FILE
+sed -i "\~$STARTUP~d" $RC_LOCAL_FILE
+
+# delete log folder in var log if they exist  
+if [ -d $LOG_DIR ]; then  
+    while true; do
+        read -p "Do you really wish to delete the log folder $LOG_DIR? [y/n]" yn
+        case $yn in
+            [Yy]* ) rm -rf $LOG_DIR; echo $LOG_DIR is deleted ; break;;
+            [Nn]* ) break;;
+            * ) echo "Please answer y or n.";;
+        esac
+    done
+fi