number of iterations limited by type #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FObersteiner
commented
Feb 4, 2025
|
OK looks fine for me now. Ended up making a larger re-write of the whole spin-up phase. Runs much more efficient now, spin-up only runs until the time budget is depleted or N_MAX_ITER exceeded. The actual N to run is chosen so that the time budget is used completely, instead of using some rather arbitrary-looking power-of-two. I think this code was from back in the days where there was no time budget. |
|
Man looks great! Liked the refactoring |
hendriknielaender
approved these changes
Feb 6, 2025
Thanks! I'll wait with the merge until the weekend if @bens wants to have a look since he contributed the runner implementation (at least the part I modified). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #98