Don't mutate the readings when calculating statistics #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't much cost to making a temporary copy of them for sorting, IMHO, and it preserves the link between the readings for each run.
bens
force-pushed
the
dont-mutate-readings
branch
from
2d11187 to
fdb2ac5
Compare
So `Results` doesn't need to carry one, and then we can use an arena for pretty printing allocations more easily.
|
💪 like the adjustments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't much cost to making a temporary copy of them for sorting, IMHO, and it preserves the link between the readings for each run. It makes the code simpler too in that
Statistics.initdoesn't need to be called with sorted readings now.