Parameterised benchmarks #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bens
force-pushed
the
parameters
branch
3 times, most recently
from
5da8da5 to
019dccb
Compare
bens
force-pushed
the
parameters
branch
3 times, most recently
from
960c5d8 to
bb63c43
Compare
|
Hoping to address #55. @adworacz, would something like this work for your needs? This should allow any parameters you could want to vary a benchmark. It would be nice to automatically format the parameters to strings similar to what hyperfine does, but it would be less straightforward than this. Hyperfine is always given strings so that makes it pretty trivial, while parameters could be anything at all in this implementation. |
bens
commented
Mar 17, 2024
|
Hmmm this is quite interesting, and is a different approach than I expected, but it certainly seems like it would work for my use case. The use of a wrapping struct for this seems actually quite powerful, in ways that I hadn't initially expected. Looks good to me, and thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is pretty simple and allows any number and type of parameters to be used, I think the API is pretty pleasant too. Despite the
@ptrCasts andanyopaques I'm pretty confident it's type safe as long as benchmarks are always added using the API functions.close #55