Fix small formatting bug, move prettyPrintHeader to utils #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After 1389ebf we forget to print a newline in the for-loop within BenchmarkResults.prettyPrint, causing messed-up formatting. We also forgot to call BenchmarkResults.getColor when determining the color for total-time. Both of these are now fixed. Also moved prettyPrintHeader to util/format.zig for consistency.
hendriknielaender
merged commit 88da272
into
hendriknielaender:main
5 of 6 checks passed
hendriknielaender
pushed a commit
that referenced
this pull request
Feb 3, 2024
After 1389ebf we forget to print a newline in the for-loop within BenchmarkResults.prettyPrint, causing messed-up formatting. We also forgot to call BenchmarkResults.getColor when determining the color for total-time. Both of these are now fixed. Also moved prettyPrintHeader to util/format.zig for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 1389ebf we forget to print a newline in the for-loop within BenchmarkResults.prettyPrint, causing messed-up formatting. We also forgot to call BenchmarkResults.getColor when determining the color for total-time. Both of these are now fixed. Also moved prettyPrintHeader to util/format.zig for consistency.