Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close memory leak with testing allocator #16

Merged
merged 4 commits into from
Nov 17, 2023
Merged

close memory leak with testing allocator #16

merged 4 commits into from
Nov 17, 2023

Conversation

FObersteiner
Copy link
Collaborator

  • pass allocator by value instead of reference
  • deinitialize the allocator after run
  • update examples, showing how to deinitialize the results memory

Copy link
Owner

@hendriknielaender hendriknielaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! The changes to the allocator management, including passing by value and ensuring it's deinitialized, are crucial fixes.

@hendriknielaender hendriknielaender merged commit 0bfd057 into hendriknielaender:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants